Molly Miller authored 5 years ago and Anna Wilcox committed 5 years ago

Includes:
* Depend on nasm; otherwise AV1 support won't be built on x86.
* Add mozconfig option --disable-elf-hack. Otherwise there's a weird
  failure in rootpkg, and according to awilfox we want to disable this
  anyway.
* Strip trailing spaces from the makedepends lines.

When opening a .CR2 Canon RAW image, attempting to load the embedded
preview for the thumbnail bar would result in a segmentation fault on
at least x86_64, with the backtrace:

Thread 4 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
[Switching to LWP 10859]
KDcrawIface::KDcraw::loadEmbeddedPreview (imgData=..., buffer=...) at /usr/src/packages/user/libkdcraw/src/libkdcraw-19.04.3/src/kdcraw.cpp:134
134     /usr/src/packages/user/libkdcraw/src/libkdcraw-19.04.3/src/kdcraw.cpp: No such file or directory.
(gdb) bt
 #0  KDcrawIface::KDcraw::loadEmbeddedPreview (imgData=..., buffer=...) at /usr/src/packages/user/libkdcraw/src/libkdcraw-19.04.3/src/kdcraw.cpp:134
 #1  0x00007ffff75c86af in Gwenview::LoadingDocumentImplPrivate::loadMetaInfo (this=0x555555f74a60)
     at /usr/src/packages/user/gwenview/src/gwenview-19.04.3/lib/document/loadingdocumentimpl.cpp:208
 #2  0x00007ffff75c6fca in non-virtual thunk to QtConcurrent::RunFunctionTask<bool>::run() () at /usr/include/c++/8.3.0/bits/exception.h:63
 #3  0x00007ffff348905c in QThreadPoolThread::run (this=0x555555c6cd40) at thread/qthreadpool.cpp:99
 #4  0x00007ffff348e18f in QThreadPrivate::start (arg=0x555555c6cd40) at thread/qthread_unix.cpp:368
 #5  0x00007ffff7db7779 in start (p=<optimized out>) at src/thread/pthread_create.c:195
 #6  0x00007ffff7dc5957 in __clone () at src/thread/x86_64/clone.s:22
(gdb) x/i $pc
=> 0x7ffff11e50f9 <KDcrawIface::KDcraw::loadEmbeddedPreview(QByteArray&, QBuffer const&)+41>:   callq  0x7ffff11e3030 <_ZN11KDcrawIface6KDcraw8rawFilesEv@plt>

This is because the thumbnail was being loaded onto the thread's stack.
Bumping the per-thread stack size to 1 MiB fixes this for all .CR2 files
I have access to.