Skip to content
Snippets Groups Projects
  1. Jan 19, 2020
  2. Jan 18, 2020
  3. Jan 17, 2020
  4. Jan 16, 2020
  5. Jan 15, 2020
  6. Jan 14, 2020
  7. Jan 13, 2020
  8. Jan 12, 2020
    • Arnd Bergmann's avatar
      drm/drm_panel: fix export of drm_panel_of_backlight, try #3 · 8d6cb2f7
      Arnd Bergmann authored
      
      Making this IS_REACHABLE() was still wrong, as that just determines
      whether the lower-level backlight code would be reachable from the panel
      driver. However, with CONFIG_DRM=y and CONFIG_BACKLIGHT_CLASS_DEVICE=m,
      the drm_panel_of_backlight is left out of drm_panel.o but the condition
      tells the driver that it is there, leading to multiple link errors such as
      
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-sitronix-st7701.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-sharp-ls043t1le01.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-seiko-43wvf1g.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-ronbo-rb070d30.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-rocktech-jh057n00900.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.ko] undefined!
      ERROR: "drm_panel_of_backlight" [drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.ko] undefined!
      
      Change the condition to check for whether the function was actually part
      of the drm module. This version of the patch survived a few hundred
      randconfig builds, so I have a good feeling this might be the last
      one for the export.
      
      Fixes: 4a34a9dc ("drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time")
      Fixes: 907aa265 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight")
      Fixes: 152dbdea ("drm/panel: add backlight support")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200107203231.920256-1-arnd@arndb.de
      8d6cb2f7
    • Arnd Bergmann's avatar
      drm: panel: fix excessive stack usage in td028ttec1_prepare · dba9bf0a
      Arnd Bergmann authored
      With gcc -O3 in combination with the structleak plug, the compiler can
      inline very aggressively, leading to rather large stack usage:
      
      drivers/gpu/drm/panel/panel-tpo-td028ttec1.c: In function 'td028ttec1_prepare':
      drivers/gpu/drm/panel/panel-tpo-td028ttec1.c:233:1: error: the frame size of 2768 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
       }
      
      Marking jbt_reg_write_*() as noinline avoids the case where
      multiple instances of this function get inlined into the same
      stack frame and each one adds a copy of 'tx_buf'.
      
      The compiler is clearly making some bad decisions here, but I
      did not open a new bug report as this only happens in combination
      with the structleak plugin.
      
      This fixes mmtom ("init/Kconfig: enable -O3 for all arches")
      
      Link: https://lore.kernel.org/lkml/CAK8P3a3jAnFZA3GFRtdYdg1-i-oih3pOQzkkrK-X3BGsFrMiZQ@mail.gmail.com/
      
      
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: Sam Ravnborg <sam@ravnborg.org> [fix indent]
      Link: https://patchwork.freedesktop.org/patch/msgid/20200108135116.3687988-1-arnd@arndb.de
      dba9bf0a
  9. Jan 11, 2020
  10. Jan 10, 2020
  11. Jan 09, 2020
Loading