Skip to content
Snippets Groups Projects

Leigh/secfixes

Merged Leigh Arber requested to merge Le1gh/packages:leigh/secfixes into current

Merge request reports

Approval is optional

Merged by Zach van RijnZach van Rijn 1 year ago (Oct 24, 2023 8:26pm UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good overall.

    For merge requests, we typically want to avoid merge commits.

    That is to say:

    git switch current
    git pull
    git switch leigh/secfixes
    git rebase current
    git push --force

    Thanks!

    Small nit: APKBUILD files are tab-based, so the arguments to cmake should be indented with two tabs, instead of one tab and two spaces. Not a big deal; we will have a tool to detect this automatically soon(tm).

    Edited by Zach van Rijn
  • Leigh Arber added 1 commit

    added 1 commit

    Compare with previous version

  • merged

Please register or sign in to reply
Loading