system/zsh: tests may fail if environment is not clean beforehand
Here's an odd one. Occurs with 5.8.1
and possibly earlier.
Imagine, for example:
cd system/zsh
export options='!check'
abuild
You might find:
...
./W01history.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./W02jobs.ztst: starting.
./W02jobs.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./X02zlevi.ztst: starting.
This test may hang the shell when it fails...
./X02zlevi.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./X03zlebindkey.ztst: starting.
./X03zlebindkey.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./X04zlehighlight.ztst: starting.
./X04zlehighlight.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./Y01completion.ztst: starting.
./Y01completion.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./Y02compmatch.ztst: starting.
./Y02compmatch.ztst: all tests successful.
../Src/zsh: Can't add module parameter `options': parameter already exists
./ztst.zsh:44: Can't add module parameter `options': parameter already exists
./ztst.zsh:zsh/parameter:44: error when adding parameter `options'
./Y03arguments.ztst: starting.
./Y03arguments.ztst: all tests successful.
**************************************
43 successful test scripts, 5 failures, 2 skipped
**************************************
make[1]: *** [Makefile:190: check] Error 1
make[1]: Leaving directory '/root/packages/system/zsh/src/zsh-5.8.1/Test'
make: *** [Makefile:263: test] Error 2
>>> ERROR: zsh: check failed
However if you don't set that variable (it should not be set in the first place):
...
./X02zlevi.ztst: all tests successful.
./X03zlebindkey.ztst: starting.
./X03zlebindkey.ztst: all tests successful.
./X04zlehighlight.ztst: starting.
./X04zlehighlight.ztst: all tests successful.
./Y01completion.ztst: starting.
./Y01completion.ztst: all tests successful.
./Y02compmatch.ztst: starting.
./Y02compmatch.ztst: all tests successful.
./Y03arguments.ztst: starting.
./Y03arguments.ztst: all tests successful.
**************************************
48 successful test scripts, 0 failures, 2 skipped
**************************************