The patch as committed was not finished.  This finishes the patch.

Tested on G5 and Power9.  No regressions on P9, 12 failures on G5 - which
is significantly better than the 3800 we had before.

Fixes: 5a785f87 ("user/node: Added fixes for pre-Power8 ppc64 CPUs")
See-also: !817

These tests fail when /etc/hosts does not contain an IPv6
entry for localhost ('::1 localhost'). It isn't immediately
clear to me whether the tests are therefore buggy, or if we
want to put the blame on a non-conforming build environment.

This was initially discovered on a system that only had an
IPv4 entry ('127.0.0.1 localhost'), which occurred because
the autobuilder tool copied /etc/{hosts,hostname,resolv.conf}
from the host into the rootfs for each build environment, and
each host may be running a different Linux distribution.

This is being addressed in adelie-infra/autobuilder#33, which
will ensure build environments are consistent in this way.

See #971.

It is not clear whether these tests ever passed in their current form.

Upstream changed these tests (and relevant code) since v16.15.0:

    https://github.com/nodejs/node/pull/41431

    https://github.com/nodejs/node/issues/43014

In v16.15.0, these tests passed on this platform, but they have been
modified in subsequent releases, and we've bumped twice since then:

    b282640c to v16.19.0
    5d1083c1 to v18.12.1

I don't see any binaries for aarch64 for either of these versions,
suggesting we never rebuilt node on aarch64 after going to v18.12.1,
likely due to the ARM builder being out of service between around
2022-12-27 and 2023-01-03. I think we just didn't catch this since
bumping to v18.12.1.

Temporarily disabling these tests to unblock progress; the
bump to v18.15.0 is for some CVEs and expected to be safe.

Anna Wilcox authored 2 years ago and Zach van Rijn committed 2 years ago

This patch reverts Node MR 43714[1], which broke time64 on pmmx.

[1]: https://github.com/nodejs/node/pull/43714

Fixes: #935

Unfortunately V8 does not support ppc and seemingly has no interest in
adopting a port.  In the future we will look for alternative JS runtimes
for running workloads on ppc.

We may also be able to package Node 12 since it has ppc support, with
the caveat that it is not well-supported upstream and will stop
receiving security updates.  This is still useful for some workloads
(Firefox builds, internal Homebridge, and such), perhaps.

Closes: #837

* The worker-stdio test no longer raises RangeError on 32-bit Intel.

* The sigint test is no longer flaky (backported from 18 branch).

* The C++ Environment handler no longer segfaults when /proc is
  unmounted.  (Submitted upstream.)

Fixes: #795