drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths
Currently we perform both short IRQ handling for DP, and connector reprobing in the HPD IRQ handler. However since we need to grab connection_mutex in order to reprobe a connector, in theory we could accidentally block ourselves from handling any short IRQs until after a modeset completes if a connector hotplug happens to occur in parallel with a modeset. I haven't seen this actually happen yet, but since we're cleaning up nouveau's hotplug handling code anyway and we already have a hpd worker, we can simply fix this by only relying on the HPD worker to actually reprobe connectors when we receive a HPD IRQ. We also add a mask to nouveau_drm to keep track of which connectors are waiting to be reprobed in response to an HPD IRQ. Signed-off-by:Lyude Paul <lyude@redhat.com> Reviewed-by:
Ben Skeggs <bskeggs@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200826182456.322681-13-lyude@redhat.com
Showing
- drivers/gpu/drm/nouveau/nouveau_connector.c 16 additions, 26 deletionsdrivers/gpu/drm/nouveau/nouveau_connector.c
- drivers/gpu/drm/nouveau/nouveau_connector.h 1 addition, 0 deletionsdrivers/gpu/drm/nouveau/nouveau_connector.h
- drivers/gpu/drm/nouveau/nouveau_display.c 63 additions, 7 deletionsdrivers/gpu/drm/nouveau/nouveau_display.c
- drivers/gpu/drm/nouveau/nouveau_display.h 1 addition, 0 deletionsdrivers/gpu/drm/nouveau/nouveau_display.h
- drivers/gpu/drm/nouveau/nouveau_dp.c 1 addition, 1 deletiondrivers/gpu/drm/nouveau/nouveau_dp.c
- drivers/gpu/drm/nouveau/nouveau_drm.c 2 additions, 2 deletionsdrivers/gpu/drm/nouveau/nouveau_drm.c
- drivers/gpu/drm/nouveau/nouveau_drv.h 2 additions, 0 deletionsdrivers/gpu/drm/nouveau/nouveau_drv.h
Loading
Please register or sign in to comment