static keys: Introduce 'struct static_key', static_key_true()/false() and...
static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]() So here's a boot tested patch on top of Jason's series that does all the cleanups I talked about and turns jump labels into a more intuitive to use facility. It should also address the various misconceptions and confusions that surround jump labels. Typical usage scenarios: #include <linux/static_key.h> struct static_key key = STATIC_KEY_INIT_TRUE; if (static_key_false(&key)) do unlikely code else do likely code Or: if (static_key_true(&key)) do likely code else do unlikely code The static key is modified via: static_key_slow_inc(&key); ... static_key_slow_dec(&key); The 'slow' prefix makes it abundantly clear that this is an expensive operation. I've updated all in-kernel code to use this everywhere. Note that I (intentionally) have not pushed through the rename blindly through to the lowest levels: the actual jump-label patching arch facility should be named like that, so we want to decouple jump labels from the static-key facility a bit. On non-jump-label enabled architectures static keys default to likely()/unlikely() branches. Signed-off-by:Ingo Molnar <mingo@elte.hu> Acked-by:
Jason Baron <jbaron@redhat.com> Acked-by:
Steven Rostedt <rostedt@goodmis.org> Cc: a.p.zijlstra@chello.nl Cc: mathieu.desnoyers@efficios.com Cc: davem@davemloft.net Cc: ddaney.cavm@gmail.com Cc: Linus Torvalds <torvalds@linux-foundation.org> Link: http://lkml.kernel.org/r/20120222085809.GA26397@elte.hu Signed-off-by:
Ingo Molnar <mingo@elte.hu>
Showing
- arch/Kconfig 20 additions, 9 deletionsarch/Kconfig
- arch/ia64/include/asm/paravirt.h 3 additions, 3 deletionsarch/ia64/include/asm/paravirt.h
- arch/ia64/kernel/paravirt.c 2 additions, 2 deletionsarch/ia64/kernel/paravirt.c
- arch/mips/include/asm/jump_label.h 1 addition, 1 deletionarch/mips/include/asm/jump_label.h
- arch/powerpc/include/asm/jump_label.h 1 addition, 1 deletionarch/powerpc/include/asm/jump_label.h
- arch/s390/include/asm/jump_label.h 1 addition, 1 deletionarch/s390/include/asm/jump_label.h
- arch/sparc/include/asm/jump_label.h 1 addition, 1 deletionarch/sparc/include/asm/jump_label.h
- arch/x86/include/asm/jump_label.h 3 additions, 3 deletionsarch/x86/include/asm/jump_label.h
- arch/x86/include/asm/paravirt.h 3 additions, 3 deletionsarch/x86/include/asm/paravirt.h
- arch/x86/kernel/kvm.c 2 additions, 2 deletionsarch/x86/kernel/kvm.c
- arch/x86/kernel/paravirt.c 2 additions, 2 deletionsarch/x86/kernel/paravirt.c
- arch/x86/kvm/mmu_audit.c 4 additions, 4 deletionsarch/x86/kvm/mmu_audit.c
- include/linux/jump_label.h 100 additions, 39 deletionsinclude/linux/jump_label.h
- include/linux/netdevice.h 2 additions, 2 deletionsinclude/linux/netdevice.h
- include/linux/netfilter.h 3 additions, 3 deletionsinclude/linux/netfilter.h
- include/linux/perf_event.h 6 additions, 6 deletionsinclude/linux/perf_event.h
- include/linux/static_key.h 1 addition, 0 deletionsinclude/linux/static_key.h
- include/linux/tracepoint.h 4 additions, 4 deletionsinclude/linux/tracepoint.h
- include/net/sock.h 3 additions, 3 deletionsinclude/net/sock.h
- kernel/events/core.c 8 additions, 8 deletionskernel/events/core.c
Loading
Please register or sign in to comment