drm/bridge: panel: Infer connector type from panel by default
The drm panel bridge creates a connector using a connector type explicitly passed by the display controller or bridge driver that instantiates the panel bridge. Now that drm_panel reports its connector type, we can use it to avoid passing an explicit (and often incorrect) connector type to drm_panel_bridge_add() and devm_drm_panel_bridge_add(). Several drivers report incorrect or unknown connector types to userspace. Reporting a different type may result in a breakage. For that reason, rename (devm_)drm_panel_bridge_add() to (devm_)drm_panel_bridge_add_typed(), and add new (devm_)drm_panel_bridge_add() functions that use the panel connector type. Update all callers of (devm_)drm_panel_bridge_add() to the _typed function, they will be converted one by one after testing. The panel drivers have been updated with the following Coccinelle semantic patch, with manual inspection and fixes to indentation. @@ expression bridge; expression dev; expression panel; identifier type; @@ ( -bridge = drm_panel_bridge_add(panel, type); +bridge = drm_panel_bridge_add_typed(panel, type); | -bridge = devm_drm_panel_bridge_add(dev, panel, type); +bridge = devm_drm_panel_bridge_add_typed(dev, panel, type); ) Signed-off-by:Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Boris Brezillon <boris.brezillon@collabora.com> Signed-off-by:
Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190904132804.29680-3-laurent.pinchart@ideasonboard.com
Showing
- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c 2 additions, 1 deletiondrivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
- drivers/gpu/drm/bridge/cdns-dsi.c 2 additions, 1 deletiondrivers/gpu/drm/bridge/cdns-dsi.c
- drivers/gpu/drm/bridge/lvds-encoder.c 2 additions, 1 deletiondrivers/gpu/drm/bridge/lvds-encoder.c
- drivers/gpu/drm/bridge/panel.c 58 additions, 11 deletionsdrivers/gpu/drm/bridge/panel.c
- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 2 additions, 1 deletiondrivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
- drivers/gpu/drm/ingenic/ingenic-drm.c 2 additions, 2 deletionsdrivers/gpu/drm/ingenic/ingenic-drm.c
- drivers/gpu/drm/mcde/mcde_dsi.c 2 additions, 2 deletionsdrivers/gpu/drm/mcde/mcde_dsi.c
- drivers/gpu/drm/pl111/pl111_drv.c 2 additions, 2 deletionsdrivers/gpu/drm/pl111/pl111_drv.c
- drivers/gpu/drm/rcar-du/rcar_du_encoder.c 2 additions, 2 deletionsdrivers/gpu/drm/rcar-du/rcar_du_encoder.c
- drivers/gpu/drm/rockchip/rockchip_rgb.c 2 additions, 1 deletiondrivers/gpu/drm/rockchip/rockchip_rgb.c
- drivers/gpu/drm/stm/ltdc.c 2 additions, 2 deletionsdrivers/gpu/drm/stm/ltdc.c
- drivers/gpu/drm/tilcdc/tilcdc_external.c 2 additions, 2 deletionsdrivers/gpu/drm/tilcdc/tilcdc_external.c
- drivers/gpu/drm/tve200/tve200_drv.c 2 additions, 2 deletionsdrivers/gpu/drm/tve200/tve200_drv.c
- drivers/gpu/drm/vc4/vc4_dpi.c 2 additions, 1 deletiondrivers/gpu/drm/vc4/vc4_dpi.c
- drivers/gpu/drm/vc4/vc4_dsi.c 2 additions, 2 deletionsdrivers/gpu/drm/vc4/vc4_dsi.c
- include/drm/drm_bridge.h 7 additions, 4 deletionsinclude/drm/drm_bridge.h
Loading
Please register or sign in to comment