drm/scheduler: rework job destruction
We now destroy finished jobs from the worker thread to make sure that we never destroy a job currently in timeout processing. By this we avoid holding lock around ring mirror list in drm_sched_stop which should solve a deadlock reported by a user. v2: Remove unused variable. v4: Move guilty job free into sched code. v5: Move sched->hw_rq_count to drm_sched_start to account for counter decrement in drm_sched_stop even when we don't call resubmit jobs if guily job did signal. v6: remove unused variable Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109692 Acked-by:Chunming Zhou <david1.zhou@amd.com> Signed-off-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Andrey Grodzovsky <andrey.grodzovsky@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/1555599624-12285-3-git-send-email-andrey.grodzovsky@amd.com
Showing
- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 3 additions, 6 deletionsdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c
- drivers/gpu/drm/etnaviv/etnaviv_dump.c 0 additions, 5 deletionsdrivers/gpu/drm/etnaviv/etnaviv_dump.c
- drivers/gpu/drm/etnaviv/etnaviv_sched.c 1 addition, 1 deletiondrivers/gpu/drm/etnaviv/etnaviv_sched.c
- drivers/gpu/drm/lima/lima_sched.c 1 addition, 1 deletiondrivers/gpu/drm/lima/lima_sched.c
- drivers/gpu/drm/panfrost/panfrost_job.c 1 addition, 1 deletiondrivers/gpu/drm/panfrost/panfrost_job.c
- drivers/gpu/drm/scheduler/sched_main.c 94 additions, 65 deletionsdrivers/gpu/drm/scheduler/sched_main.c
- drivers/gpu/drm/v3d/v3d_sched.c 1 addition, 1 deletiondrivers/gpu/drm/v3d/v3d_sched.c
- include/drm/gpu_scheduler.h 1 addition, 5 deletionsinclude/drm/gpu_scheduler.h
Loading
Please register or sign in to comment