Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
R
R128
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Ermine
R128
Commits
55252da1
Commit
55252da1
authored
9 years ago
by
Ben Skeggs
Browse files
Options
Downloads
Patches
Plain Diff
drm/nouveau/fifo/gk104: identify fault-recovery members more clearly
Signed-off-by:
Ben Skeggs
<
bskeggs@redhat.com
>
parent
6d39b83f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
+8
-8
8 additions, 8 deletions
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.h
+4
-2
4 additions, 2 deletions
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.h
with
12 additions
and
10 deletions
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c
+
8
−
8
View file @
55252da1
...
...
@@ -109,9 +109,9 @@ gk104_fifo_engine(struct gk104_fifo *fifo, u32 engn)
}
static
void
gk104_fifo_recover_work
(
struct
work_struct
*
w
ork
)
gk104_fifo_recover_work
(
struct
work_struct
*
w
)
{
struct
gk104_fifo
*
fifo
=
container_of
(
w
ork
,
typeof
(
*
fifo
),
fault
);
struct
gk104_fifo
*
fifo
=
container_of
(
w
,
typeof
(
*
fifo
),
recover
.
work
);
struct
nvkm_device
*
device
=
fifo
->
base
.
engine
.
subdev
.
device
;
struct
nvkm_engine
*
engine
;
unsigned
long
flags
;
...
...
@@ -119,8 +119,8 @@ gk104_fifo_recover_work(struct work_struct *work)
u64
mask
,
todo
;
spin_lock_irqsave
(
&
fifo
->
base
.
lock
,
flags
);
mask
=
fifo
->
mask
;
fifo
->
mask
=
0ULL
;
mask
=
fifo
->
recover
.
mask
;
fifo
->
recover
.
mask
=
0ULL
;
spin_unlock_irqrestore
(
&
fifo
->
base
.
lock
,
flags
);
for
(
todo
=
mask
;
engn
=
__ffs64
(
todo
),
todo
;
todo
&=
~
(
1
<<
engn
))
...
...
@@ -155,8 +155,8 @@ gk104_fifo_recover(struct gk104_fifo *fifo, struct nvkm_engine *engine,
list_del_init
(
&
chan
->
head
);
chan
->
killed
=
true
;
fifo
->
mask
|=
1ULL
<<
engine
->
subdev
.
index
;
schedule_work
(
&
fifo
->
fault
);
fifo
->
recover
.
mask
|=
1ULL
<<
engine
->
subdev
.
index
;
schedule_work
(
&
fifo
->
recover
.
work
);
}
static
const
struct
nvkm_enum
...
...
@@ -651,7 +651,7 @@ gk104_fifo_fini(struct nvkm_fifo *base)
{
struct
gk104_fifo
*
fifo
=
gk104_fifo
(
base
);
struct
nvkm_device
*
device
=
fifo
->
base
.
engine
.
subdev
.
device
;
flush_work
(
&
fifo
->
fault
);
flush_work
(
&
fifo
->
recover
.
work
);
/* allow mmu fault interrupts, even when we're not using fifo */
nvkm_mask
(
device
,
0x002140
,
0x10000000
,
0x10000000
);
}
...
...
@@ -755,7 +755,7 @@ gk104_fifo_new_(const struct nvkm_fifo_func *func, struct nvkm_device *device,
if
(
!
(
fifo
=
kzalloc
(
sizeof
(
*
fifo
),
GFP_KERNEL
)))
return
-
ENOMEM
;
INIT_WORK
(
&
fifo
->
fault
,
gk104_fifo_recover_work
);
INIT_WORK
(
&
fifo
->
recover
.
work
,
gk104_fifo_recover_work
);
*
pfifo
=
&
fifo
->
base
;
return
nvkm_fifo_ctor
(
func
,
device
,
index
,
nr
,
&
fifo
->
base
);
...
...
This diff is collapsed.
Click to expand it.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.h
+
4
−
2
View file @
55252da1
...
...
@@ -16,8 +16,10 @@ struct gk104_fifo_engn {
struct
gk104_fifo
{
struct
nvkm_fifo
base
;
struct
work_struct
fault
;
u64
mask
;
struct
{
struct
work_struct
work
;
u64
mask
;
}
recover
;
int
pbdma_nr
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment