Skip to content
Snippets Groups Projects
Unverified Commit 0c02cebc authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/display: Fix HDMI state helper dependency


During the life of the series that introduced the
DRM_DISPLAY_HDMI_STATE_HELPER option, we reworked the Kconfig option
dependency setup to rely on depends on with commit f6d2dc03 ("drm:
Switch DRM_DISPLAY_HDMI_HELPER to depends on") which got reverted later
on because it was creating too many issues by commit d7c128cb
("Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on"").

However, since the series was out of tree at that time,
DRM_DISPLAY_HDMI_STATE_HELPER wasn't properly updated to take the revert
into account and is now creating build issues.

Let's switch the depends on to a select to fix this.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405290332.Sqtt0ix0-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202405290438.TOYhXMIn-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202405290803.c3178DYT-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202405291109.PQdqc46g-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202405291221.a0NStxHE-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202405291636.8GgBtK8u-lkp@intel.com/


Fixes: 54cb39e2 ("drm/connector: hdmi: Create an HDMI sub-state")
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240529080013.2325748-1-mripard@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 822f89a4
No related branches found
Tags drm-misc-fixes-2024-03-07
No related merge requests found
...@@ -74,6 +74,6 @@ config DRM_DISPLAY_HDMI_HELPER ...@@ -74,6 +74,6 @@ config DRM_DISPLAY_HDMI_HELPER
config DRM_DISPLAY_HDMI_STATE_HELPER config DRM_DISPLAY_HDMI_STATE_HELPER
bool bool
depends on DRM_DISPLAY_HELPER depends on DRM_DISPLAY_HELPER
depends on DRM_DISPLAY_HDMI_HELPER select DRM_DISPLAY_HDMI_HELPER
help help
DRM KMS state helpers for HDMI. DRM KMS state helpers for HDMI.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment