drm: Nuke mode->vrefresh
Get rid of mode->vrefresh and just calculate it on demand. Saves a bit of space and avoids the cached value getting out of sync with reality. Mostly done with cocci, with the following manual fixups: - Remove the now empty loop in drm_helper_probe_single_connector_modes() - Fix __MODE() macro in ch7006_mode.c - Fix DRM_MODE_ARG() macro in drm_modes.h - Remove leftover comment from samsung_s6d16d0_mode - Drop the TODO @@ @@ struct drm_display_mode { ... - int vrefresh; ... }; @@ identifier N; expression E; @@ struct drm_display_mode N = { - .vrefresh = E }; @@ identifier N; expression E; @@ struct drm_display_mode N[...] = { ..., { - .vrefresh = E } ,... }; @@ expression E; @@ { DRM_MODE(...), - .vrefresh = E, } @@ identifier M, R; @@ int drm_mode_vrefresh(const struct drm_display_mode *M) { ... - if (M->vrefresh > 0) - R = M->vrefresh; - else if (...) { ... } ... } @@ struct drm_display_mode *p; expression E; @@ ( - p->vrefresh = E; | - p->vrefresh + drm_mode_vrefresh(p) ) @@ struct drm_display_mode s; expression E; @@ ( - s.vrefresh = E; | - s.vrefresh + drm_mode_vrefresh(&s) ) @@ expression E; @@ - drm_mode_vrefresh(E) ? drm_mode_vrefresh(E) : drm_mode_vrefresh(E) + drm_mode_vrefresh(E) @find_substruct@ identifier X; identifier S; @@ struct X { ... struct drm_display_mode S; ... }; @@ identifier find_substruct.S; expression E; identifier I; @@ { .S = { - .vrefresh = E } } @@ identifier find_substruct.S; identifier find_substruct.X; expression E; identifier I; @@ struct X I[...] = { ..., .S = { - .vrefresh = E } ,... }; v2: Drop TODO v3: Rebase v4: Rebase Cc: Andrzej Hajda <a.hajda@samsung.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Jernej Skrabec <jernej.skrabec@siol.net> Cc: Inki Dae <inki.dae@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: CK Hu <ck.hu@mediatek.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jerry Han <hanxu5@huaqin.corp-partner.google.com> Cc: Icenowy Zheng <icenowy@aosc.io> Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Stefan Mavrodiev <stefan@olimex.com> Cc: Robert Chiras <robert.chiras@nxp.com> Cc: "Guido Günther" <agx@sigxcpu.org> Cc: Purism Kernel Team <kernel@puri.sm> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Vincent Abriou <vincent.abriou@st.com> Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> Cc: Thomas Hellstrom <thellstrom@vmware.com> Cc: linux-amlogic@lists.infradead.org Cc: nouveau@lists.freedesktop.org Reviewed-by:Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Sam Ravnborg <sam@ravnborg.org> Acked-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200428171940.19552-4-ville.syrjala@linux.intel.com
Showing
- Documentation/gpu/todo.rst 0 additions, 20 deletionsDocumentation/gpu/todo.rst
- drivers/gpu/drm/bridge/sii902x.c 1 addition, 1 deletiondrivers/gpu/drm/bridge/sii902x.c
- drivers/gpu/drm/drm_client_modeset.c 1 addition, 1 deletiondrivers/gpu/drm/drm_client_modeset.c
- drivers/gpu/drm/drm_edid.c 161 additions, 167 deletionsdrivers/gpu/drm/drm_edid.c
- drivers/gpu/drm/drm_modes.c 3 additions, 6 deletionsdrivers/gpu/drm/drm_modes.c
- drivers/gpu/drm/drm_probe_helper.c 0 additions, 3 deletionsdrivers/gpu/drm/drm_probe_helper.c
- drivers/gpu/drm/exynos/exynos_hdmi.c 3 additions, 2 deletionsdrivers/gpu/drm/exynos/exynos_hdmi.c
- drivers/gpu/drm/exynos/exynos_mixer.c 1 addition, 1 deletiondrivers/gpu/drm/exynos/exynos_mixer.c
- drivers/gpu/drm/i2c/ch7006_mode.c 0 additions, 1 deletiondrivers/gpu/drm/i2c/ch7006_mode.c
- drivers/gpu/drm/i915/display/intel_display.c 0 additions, 1 deletiondrivers/gpu/drm/i915/display/intel_display.c
- drivers/gpu/drm/i915/display/intel_display_debugfs.c 2 additions, 2 deletionsdrivers/gpu/drm/i915/display/intel_display_debugfs.c
- drivers/gpu/drm/i915/display/intel_dp.c 5 additions, 5 deletionsdrivers/gpu/drm/i915/display/intel_dp.c
- drivers/gpu/drm/i915/display/intel_tv.c 0 additions, 3 deletionsdrivers/gpu/drm/i915/display/intel_tv.c
- drivers/gpu/drm/mcde/mcde_dsi.c 3 additions, 3 deletionsdrivers/gpu/drm/mcde/mcde_dsi.c
- drivers/gpu/drm/mediatek/mtk_drm_crtc.c 2 additions, 2 deletionsdrivers/gpu/drm/mediatek/mtk_drm_crtc.c
- drivers/gpu/drm/mediatek/mtk_hdmi.c 1 addition, 1 deletiondrivers/gpu/drm/mediatek/mtk_hdmi.c
- drivers/gpu/drm/meson/meson_venc_cvbs.c 0 additions, 2 deletionsdrivers/gpu/drm/meson/meson_venc_cvbs.c
- drivers/gpu/drm/nouveau/nouveau_connector.c 2 additions, 3 deletionsdrivers/gpu/drm/nouveau/nouveau_connector.c
- drivers/gpu/drm/panel/panel-arm-versatile.c 0 additions, 4 deletionsdrivers/gpu/drm/panel/panel-arm-versatile.c
- drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c 0 additions, 1 deletiondrivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
Loading
Please register or sign in to comment